k256: add expose-field feature; fix/CI benches#161
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #161 +/- ##
=======================================
Coverage 60.25% 60.25%
=======================================
Files 25 25
Lines 3555 3555
=======================================
Hits 2142 2142
Misses 1413 1413
Continue to review full report at Codecov.
|
The benchmarks want direct access to `FieldElement` for benchmarking purposes. This is a legitimate use case, but breaks encapsulation in that we'd like to generally prevent exposure of `FieldElement` except for "hazmat"-style use cases. This is a well-recognized problem with Rust in general: rust-lang/cargo#2911 This commit adds a semi-hidden `expose-field` feature in order to fix the benchmark. Perhaps it will be abused, but the alternative is not having a benchmark, which seems bad too. It also adds a CI build step to ensure the benchmarks compile to prevent this sort of regression in the future.
tarcieri
force-pushed
the
k256/expose-field
branch
from
a6c9ba8 to
9621c1f
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The benchmarks want direct access to
FieldElementfor benchmarking purposes. This is a legitimate use case, but breaks encapsulation in that we'd like to generally prevent exposure ofFieldElementexcept for "hazmat"-style use cases.This is a well-recognized problem with Rust in general: rust-lang/cargo#2911
This commit adds a semi-hidden
expose-fieldfeature in order to fix the benchmark. Perhaps it will be abused, but the alternative is not having a benchmark, which seems bad too.It also adds a CI build step to ensure the benchmarks compile to prevent this sort of regression in the future.