k256: implement AffinePoint::identity() and ::is_identity()#165
Merged
Conversation
tarcieri
force-pushed
the
k256/affine-identity
branch
3 times, most recently
from
19fd272 to
8f1c5c7
Compare
tarcieri
changed the title
AffinePoint::identity() and ::is_identity()AffinePoint::identity() and ::is_identity()
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
==========================================
+ Coverage 60.14% 60.35% +0.21%
==========================================
Files 25 25
Lines 3555 3572 +17
==========================================
+ Hits 2138 2156 +18
+ Misses 1417 1416 -1
Continue to review full report at Codecov.
|
Adds a `Choice` field to `AffinePoint` which encodes whether the point represents the point at infinity. Inspired by the method used in the `bls12_381` crate: https://github.com/zkcrypto/bls12_381/blob/0d2c06dd/src/g1.rs#L25-L29
tarcieri
force-pushed
the
k256/affine-identity
branch
from
8f1c5c7 to
1131ff8
Compare
tarcieri
added a commit
that referenced
this pull request
Sep 5, 2020
This is a corresponding change ala #165, but for the `p256` crate.
tarcieri
added a commit
that referenced
this pull request
Sep 5, 2020
This is a corresponding change ala #165, but for the `p256` crate.
tarcieri
added a commit
that referenced
this pull request
Sep 5, 2020
This is a corresponding change ala #165, but for the `p256` crate.
tarcieri
added a commit
that referenced
this pull request
Sep 5, 2020
This is a corresponding change ala #165, but for the `p256` crate.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
Choicefield toAffinePointwhich encodes whether the point represents the point at infinity.Inspired by the method used in the
bls12_381crate:https://github.com/zkcrypto/bls12_381/blob/0d2c06dd/src/g1.rs#L25-L29