p256: impl ff and group traits#169
Merged
Merged
Conversation
tarcieri
commented
Sep 6, 2020
Comment on lines
+128
to
+131
| // TODO(tarcieri); stub! | ||
| fn sqrt(&self) -> CtOption<Self> { | ||
| todo!(); | ||
| } |
tarcieri
commented
Sep 6, 2020
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
==========================================
- Coverage 59.43% 58.38% -1.06%
==========================================
Files 25 25
Lines 3688 3775 +87
==========================================
+ Hits 2192 2204 +12
- Misses 1496 1571 +75
Continue to review full report at Codecov.
|
tarcieri
force-pushed
the
k256/ff-and-group-traits
branch
from
8bfa8b6 to
fda0c0b
Compare
Member
Author
|
Ugh, named the branch incorrectly, oh well 😅 |
tarcieri
commented
Sep 6, 2020
|
|
||
| const NUM_BITS: u32 = 256; | ||
| const CAPACITY: u32 = 256; | ||
| const S: u32 = 3; |
Member
Author
There was a problem hiding this comment.
If I did this right, the relevant byte is 0xb9 - 1:
10111000
Corresponding change to #164, but for the `p256` crate. - Impls `ff::{Field, PrimeField}` on `Scalar` - Impls `group::{Group, Curve}` on `ProjectivePoint`
tarcieri
force-pushed
the
k256/ff-and-group-traits
branch
from
fda0c0b to
fb19fcd
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corresponding change to #164, but for the
p256crate.ff::{Field, PrimeField}onScalargroup::{Group, Curve}onProjectivePoint