Skip to content

k256/p256: remove Generate trait#175

Merged
tarcieri merged 1 commit into
masterfrom
remove-generate-trait
Sep 9, 2020
Merged

k256/p256: remove Generate trait#175
tarcieri merged 1 commit into
masterfrom
remove-generate-trait

Conversation

@tarcieri

@tarcieri tarcieri commented Sep 9, 2020

Copy link
Copy Markdown
Member

It's been replaced by methods like Field::random and Group::random.

See: RustCrypto/traits#295

It's been replaced by methods like `Field::random` and `Group::random`.

See: RustCrypto/traits#295
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #175 into master will increase coverage by 0.07%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
+ Coverage   58.21%   58.28%   +0.07%     
==========================================
  Files          25       25              
  Lines        3786     3778       -8     
==========================================
- Hits         2204     2202       -2     
+ Misses       1582     1576       -6     
Impacted Files Coverage Δ
k256/src/ecdsa.rs 85.71% <ø> (ø)
k256/src/ecdsa/recoverable.rs 62.33% <ø> (ø)
k256/src/ecdsa/sign.rs 30.90% <0.00%> (ø)
p256/src/arithmetic/scalar.rs 77.41% <ø> (+0.29%) ⬆️
p256/src/ecdsa.rs 90.47% <ø> (ø)
k256/src/arithmetic.rs 100.00% <100.00%> (ø)
k256/src/arithmetic/scalar.rs 76.02% <100.00%> (+1.12%) ⬆️
p256/src/arithmetic.rs 100.00% <100.00%> (ø)
p256/src/arithmetic/scalar/blinding.rs 91.66% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd9e231...b988380. Read the comment docs.

@tarcieri tarcieri merged commit ab8800a into master Sep 9, 2020
@tarcieri tarcieri deleted the remove-generate-trait branch September 9, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants