p256: make AffinePoint::generator closer to const-friendly#509
Merged
Conversation
This is a stepping stone towards solving #508. Replaces the implementation of `AffinePoint::generator` with one that uses Rust literal syntax to construct the field elements which represent the base point's affine coordinates. Coordinates are specified in canonical form for easy auditability, then converted to Montgomery form. With `const fn`, this conversion could happen completely at compile time. This can't yet be made fully `const` though, as there isn't a `const fn` constructor for `subtle::Choice`, which is used to represent the point at infinity.
tarcieri
force-pushed
the
p256/more-const-friendly-generator-impl
branch
from
6ae32b9 to
9b7ff79
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a stepping stone towards solving #508 for
p256.Replaces the implementation of
AffinePoint::generatorwith one that uses Rust literal syntax to construct the field elements which represent the base point's affine coordinates.Coordinates are specified in canonical form for easy auditability, then converted to Montgomery form. With
const fn, this conversion could happen completely at compile time.This can't yet be made fully
constthough, as there isn't aconst fnconstructor forsubtle::Choice, which is used to represent the point at infinity.