k256: impl ConstantTimeEq for Scalar; is_zero()#66
Merged
Conversation
Adds an impl of `subtle::ConstantTimeEq` on `Scalar`. Uses that impl to define `Scalar::is_zero`, and then uses `is_zero` within the `Neg` impl.
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
==========================================
+ Coverage 81.46% 81.50% +0.03%
==========================================
Files 12 12
Lines 1392 1395 +3
==========================================
+ Hits 1134 1137 +3
Misses 258 258
Continue to review full report at Codecov.
|
Merged
tarcieri
added a commit
that referenced
this pull request
Jul 11, 2020
Adds an impl of `subtle::ConstantTimeEq` on `Scalar`. Uses that impl to define `Scalar::is_zero`, and then uses `is_zero` within the `Neg` impl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an impl of
subtle::ConstantTimeEqonScalar.Uses that impl to define
Scalar::is_zero, and then usesis_zerowithin theNegimpl.