[WIP] Add ECDSA primitive traits to the elliptic-curve crate#69
[WIP] Add ECDSA primitive traits to the elliptic-curve crate#69tarcieri wants to merge 1 commit into
elliptic-curve crate#69Conversation
Adds a set of low-level "hazmat" traits to the `elliptic-curve` crate for implementing ECDSA signing, verification, and public key recovery. These primitives allow crates containing implementations of specific curves to define core ECDSA functionality in a coarse-grained manner which can potentially leverage things like assembly or hardware cryptographic accelerators.
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
=======================================
Coverage 81.50% 81.50%
=======================================
Files 12 12
Lines 1395 1395
=======================================
Hits 1137 1137
Misses 258 258 Continue to review full report at Codecov.
|
|
I put these traits in this crate in this PR because presently the Another option is to put these traits in the I think that approach would actually make the most sense:
All the rest of that said, I really like this approach over #65 and #67. I think it addresses @nickray's concerns in #55 about assembly-based optimizations by having the trait express a coarse-grained ECDSA implementation. |
|
Here's similar (actually, much simpler!) traits implemented in the I definitely prefer that approach over this one, so I'm going to go ahead and close this out. |
(Another alternative to #65 and #67 with the goal of generic cross-curve ECDSA support)
Adds a set of low-level "hazmat" traits to the
elliptic-curvecrate for implementing ECDSA signing, verification, and public key recovery.These primitives allow crates containing implementations of specific curves to define core ECDSA functionality in a coarse-grained manner which can potentially leverage things like assembly or hardware cryptographic accelerators.