Skip to content

Bump elliptic-curve to v0.13.0-pre.1#730

Merged
tarcieri merged 5 commits into
masterfrom
elliptic-curve/v0.13.0-pre.1
Feb 1, 2023
Merged

Bump elliptic-curve to v0.13.0-pre.1#730
tarcieri merged 5 commits into
masterfrom
elliptic-curve/v0.13.0-pre.1

Conversation

@tarcieri

Copy link
Copy Markdown
Member

Bumps elliptic-curve to the latest prerelease, with ecdsa v0.16.0-pre sourced from git.

@tarcieri tarcieri force-pushed the elliptic-curve/v0.13.0-pre.1 branch 9 times, most recently from 576a00b to 0c3b447 Compare January 30, 2023 22:50
@tarcieri tarcieri force-pushed the elliptic-curve/v0.13.0-pre.1 branch 2 times, most recently from cd90722 to 32cf276 Compare January 30, 2023 23:44
@tarcieri tarcieri requested review from fjarri and str4d January 31, 2023 03:09
@tarcieri tarcieri force-pushed the elliptic-curve/v0.13.0-pre.1 branch from 32cf276 to 662c462 Compare January 31, 2023 03:14
@tarcieri

Copy link
Copy Markdown
Member Author

@fjarri @str4d could definitely do with a cross-check on this as it contains the ff/group v0.13 upgrade as well (which I need to get into the commit message).

Some of the constants are still TODOs which I can take a look at soon.

Comment thread k256/src/arithmetic/field.rs Outdated
Comment thread k256/src/arithmetic/field.rs
Comment thread k256/src/arithmetic/field.rs Outdated
Comment thread k256/src/arithmetic/scalar.rs Outdated
Comment thread k256/src/arithmetic/scalar.rs Outdated
Bumps `elliptic-curve` to the latest prerelease, with `ecdsa`
v0.16.0-pre sourced from git.

This includes upgrades to the v0.13 releases of the `ff`/`group` crates.
@tarcieri tarcieri force-pushed the elliptic-curve/v0.13.0-pre.1 branch from 922a9e6 to 9a764c1 Compare January 31, 2023 21:30
Has the impls with borrowed `Item` call the owned impls after
`.copied()`
Originally by @fjarri. Imported from:

fjarri@d7de9bf
The issues leading to them have been resolved
@tarcieri

Copy link
Copy Markdown
Member Author

In the interest of unblocking other work, I'd like to get this merged ASAP.

I made a tracking ticket for the constants which are presently TODOs: #731

They should be pretty easy to calculate once I get sage reinstalled.

@tarcieri tarcieri marked this pull request as ready for review January 31, 2023 23:12
@tarcieri tarcieri changed the title [WIP] Bump elliptic-curve to v0.13.0-pre.1 Bump elliptic-curve to v0.13.0-pre.1 Jan 31, 2023
@fjarri

fjarri commented Jan 31, 2023

Copy link
Copy Markdown
Contributor

They should be pretty easy to calculate once I get sage reinstalled.

I used the online version to calculate the constants for k256 because it's such a pain to install

@fjarri

fjarri commented Jan 31, 2023

Copy link
Copy Markdown
Contributor

Speaking of k256 constants, ideally someone should calculate them independently and cross-check.

@tarcieri

Copy link
Copy Markdown
Member Author

I can also cross-check when I figure out a sage solution. Will try the online version if I can't get it working locally.

@tarcieri tarcieri merged commit 3bdc072 into master Feb 1, 2023
@tarcieri tarcieri deleted the elliptic-curve/v0.13.0-pre.1 branch February 1, 2023 00:51
This was referenced Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants