p256: Implement scalar arithmetic via Barrett reduction#83
Merged
Conversation
40b7b90 to
1eb82c5
Compare
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
==========================================
+ Coverage 52.72% 53.70% +0.98%
==========================================
Files 17 17
Lines 3124 3374 +250
==========================================
+ Hits 1647 1812 +165
- Misses 1477 1562 +85
Continue to review full report at Codecov.
|
Member
Author
Member
|
@tarcieri sure, go ahead with both, happy to see signatures appear! Nothing obvious missing, apart from a potential code detail review and more testing, which perhaps comes later? |
Member
Author
|
Sounds good, will go ahead and move forward with this. I think if we can get ECDSA to a PoC stage, there are some other interested parties who can help work on improving P-256 scalar arithmetic (and ideally with that, improving testing). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cherry picks @nickray's original #56 onto the latest code.
I also removed the
expose-arithmeticfeature/gating as I think it should no longer be necessary.With this I think it should be possible to implement
ecdsa::hazmat::SignPrimitiveala the implementation in #79 for secp256k1.