Skip to content

p256: ecdsa::hazmat::{SignPrimitive, VerifyPrimitive}#84

Merged
tarcieri merged 1 commit into
masterfrom
p256/ecdsa-sign-primitive
Jul 24, 2020
Merged

p256: ecdsa::hazmat::{SignPrimitive, VerifyPrimitive}#84
tarcieri merged 1 commit into
masterfrom
p256/ecdsa-sign-primitive

Conversation

@tarcieri

@tarcieri tarcieri commented Jul 22, 2020

Copy link
Copy Markdown
Member

This PR combines parts of #57 and #79 to implement the low-level ECDSA signing interface for P-256.

@tarcieri tarcieri requested a review from nickray July 22, 2020 21:35
@codecov-commenter

codecov-commenter commented Jul 22, 2020

Copy link
Copy Markdown

Codecov Report

Merging #84 into master will decrease coverage by 0.56%.
The diff coverage is 9.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
- Coverage   53.70%   53.13%   -0.57%     
==========================================
  Files          17       18       +1     
  Lines        3374     3408      +34     
==========================================
- Hits         1812     1811       -1     
- Misses       1562     1597      +35     
Impacted Files Coverage Δ
p256/src/arithmetic.rs 82.59% <0.00%> (ø)
p256/src/ecdsa.rs 0.00% <0.00%> (ø)
p256/src/arithmetic/scalar.rs 66.43% <50.00%> (-0.46%) ⬇️
k256/src/arithmetic.rs 85.13% <100.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 061a1a2...eae2c63. Read the comment docs.

@tarcieri tarcieri force-pushed the p256/ecdsa-sign-primitive branch 2 times, most recently from 7b4a3df to eae2c63 Compare July 22, 2020 22:11
@tarcieri tarcieri changed the title [WIP] p256: impl ecdsa::hazmat::SignPrimitive [WIP] ecdsa::hazmat::{SignPrimitive, VerifyPrimitive} Jul 22, 2020
@tarcieri tarcieri force-pushed the p256/ecdsa-sign-primitive branch from eae2c63 to f161380 Compare July 24, 2020 01:46
@tarcieri tarcieri changed the title [WIP] ecdsa::hazmat::{SignPrimitive, VerifyPrimitive} ecdsa::hazmat::{SignPrimitive, VerifyPrimitive} Jul 24, 2020
@tarcieri tarcieri force-pushed the p256/ecdsa-sign-primitive branch from f161380 to 4e322cf Compare July 24, 2020 01:52
@tarcieri tarcieri marked this pull request as ready for review July 24, 2020 01:52
@tarcieri tarcieri merged commit 62af947 into master Jul 24, 2020
@tarcieri tarcieri deleted the p256/ecdsa-sign-primitive branch July 24, 2020 02:09
@tarcieri tarcieri changed the title ecdsa::hazmat::{SignPrimitive, VerifyPrimitive} p256: ecdsa::hazmat::{SignPrimitive, VerifyPrimitive} Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants