k256/p256: impl Generate for Scalar types#90
Merged
Merged
Conversation
Impls the new trait for random generation added in RustCrypto/traits#220. This can potentially be used to completely replace the `GenerateSecretKey` trait, since that can now be made a conditionally impl'd inherent method on `SecretKey` with where bounds on `Scalar: Generate`.
tarcieri
force-pushed
the
scalar-generate
branch
from
1f39a77 to
66644ab
Compare
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
==========================================
- Coverage 53.19% 53.10% -0.10%
==========================================
Files 18 18
Lines 3412 3418 +6
==========================================
Hits 1815 1815
- Misses 1597 1603 +6
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Impls the new trait for random generation added in RustCrypto/traits#220.
This can potentially be used to completely replace the
GenerateSecretKeytrait, since that can now be made a conditionally impl'd inherent method onSecretKeywith where bounds onScalar: Generate.