sha3: Add cross tests#339
Merged
Merged
Conversation
aewag
force-pushed
the
add-cross-tests
branch
13 times, most recently
from
bdf4ee4 to
3738f08
Compare
aewag
force-pushed
the
add-cross-tests
branch
16 times, most recently
from
0c5fc3e to
a977119
Compare
aewag
force-pushed
the
add-cross-tests
branch
26 times, most recently
from
e88f7f7 to
d36ce21
Compare
tarcieri
approved these changes
Dec 18, 2021
tarcieri
left a comment
tarcieri
left a comment
Member
There was a problem hiding this comment.
Interesting. TIL composite actions.
Looks good to me, but I'll let @newpavlov review as well.
Member
|
Going to merge this. It seems good for |
Contributor
Author
|
Thanks. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well, that escalated quickly... Sorry for any noise!
This PR adds cross-tests to
sha3crate. It does so by using the composite action namedcross-tests, which can be found in.github/actions/cross-tests/action.ymlInputs to the
cross-testsactions are: Rust Version, Package, Target & FeaturesI adapted the
sha1&sha2crate to use the same composite action to reduce duplicated code (other crates seemed not to use any cross-tests).Further I changed the place where
MSRVis defined. It now can be set in theenvsection in the beginning of the.ymlfile at a single place.Disadvantage: It needs one job run before anything else to distribute it. But that could also be used in the future to create the Strategy Matrix at a single place and distribute it to the jobs.
Issue came up in #338