Bump password-hash to 0.1.2 due to breaking change#147
Conversation
I had a use case where I was using the v0.7.3 of `pbkdf2`, and when dependabot bumped to v0.7.4 there was an error with compiling `pbkdf2`:
```
if Base64::decode(count, &mut count_arr)?.len() != 4 {
| ^ the trait `From<base64ct::Error>` is not implemented for `HasherError`
...
```
I found that this is due to my version of `password-hash` being stuck on v0.1.1. Once I did a `cargo update -p password-hash` all was resolved.
|
Aah, okay. This looks like an accidental SemVer breaking change I wasn't expecting while bumping I tried addressing it in an alternative way: yanking the v0.1.1 release so v0.1.2 is the only version published. If you'd like, I can merge this too. |
|
@tarcieri I see...Not sure how that happened then. Maybe the correct thing for me to have done was It isn't a blocker anymore for me, so it's up to you to close or merge 😌 Thanks! |
|
It's really an oversight on my part for pushing out a SemVer-breaking release. I believed all the usages of Anyway, I think yanking the previous releases is sufficient to address this issue, so I'm going to close this. |
…mac-in-dev-macro crypto-mac: use NewMac in test macros
I had a use case where I was using the v0.7.3 of
pbkdf2, and when dependabot bumped to v0.7.4 there was an error with compilingpbkdf2:I found that this is due to my version of
password-hashbeing stuck on v0.1.1. Once I did acargo update -p password-hashall was resolved.