argon2: eliminate redundant checks added in #135#181
Merged
Conversation
Now that error handling has been improved in `password-hash` v0.2, these are no longer needed as the errors will be properly handled in the `hash_password_into` function.
tarcieri
force-pushed
the
argon2/eliminate-redundant-checks
branch
from
b0eedcd to
52011a0
Compare
dns2utf8
pushed a commit
to dns2utf8/password-hashes
that referenced
this pull request
Jan 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that error handling has been improved in
password-hashv0.2, these are no longer needed as the errors will be properly handled in thehash_password_intofunction.