Skip to content

Argon2 impl Debug#423

Merged
tarcieri merged 2 commits into
RustCrypto:masterfrom
RoDmitry:patch-1
Jun 14, 2023
Merged

Argon2 impl Debug#423
tarcieri merged 2 commits into
RustCrypto:masterfrom
RoDmitry:patch-1

Conversation

@RoDmitry

Copy link
Copy Markdown
Contributor

No description provided.

@tarcieri

Copy link
Copy Markdown
Member

The Argon2 struct contains a secret field which a blanket Debug impl like this will reveal.

Instead it needs a handwritten one which uses debug_struct and omits the secret field, either substituting e.g. an ellipsis "..." for the secret field or using finish_non_exhaustive.

@RoDmitry

Copy link
Copy Markdown
Contributor Author

Done using finish_non_exhaustive

@RoDmitry RoDmitry changed the title Argon2 derive Debug Argon2 impl Debug Jun 14, 2023

@tarcieri tarcieri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@tarcieri tarcieri merged commit eccda35 into RustCrypto:master Jun 14, 2023
@RoDmitry RoDmitry deleted the patch-1 branch June 15, 2023 10:18
@tarcieri tarcieri mentioned this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants