Skip to content

argon2: add Params::DEFAULT constant#439

Merged
tarcieri merged 1 commit into
masterfrom
argon2/default-params-constant
Jul 3, 2023
Merged

argon2: add Params::DEFAULT constant#439
tarcieri merged 1 commit into
masterfrom
argon2/default-params-constant

Conversation

@tarcieri

@tarcieri tarcieri commented Jul 3, 2023

Copy link
Copy Markdown
Member

Allows for accessing default parameters in const contexts

Allows for accessing default parameters in const contexts
@tarcieri tarcieri merged commit 3571f10 into master Jul 3, 2023
@tarcieri tarcieri deleted the argon2/default-params-constant branch July 3, 2023 15:53
@C0D3-M4513R

Copy link
Copy Markdown
Contributor

Yes, but not as customizable.
I cannot store a custom const default Params object

@tarcieri

tarcieri commented Jul 3, 2023

Copy link
Copy Markdown
Member Author

That seems at odds with the notion of a default, especially in this context: we have specially selected the OWASP recommended parameters specifically so you don't have to customize them.

If you want customization, by definition you are not using the default.

@tarcieri tarcieri mentioned this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants