argon2: detect allocation failures in hash_password_into#568
Conversation
jonasmalacofilho
left a comment
There was a problem hiding this comment.
Note that my allocation-only benchmark in #566 suggests this could be a tiny bit slower than vec![Block::default, ...].
So maybe it would be good to benchmark this with high-ish memory sizes, or at least with the 19 MiB and 46 MiB sizes recommended by OWASP?
|
Maybe we should try to land #547 first so we can gauge any impact on performance? |
I think we should merge this PR, then #547 without the alignment workaround after it was migrated to |
Closes #566