scrypt: enable and fix workspace-level lints#892
Merged
Conversation
tarcieri
commented
Apr 21, 2026
Comment on lines
19
to
-21
| mod soft; | ||
| pub(crate) use soft::scrypt_block_mix; | ||
|
|
||
| pub(crate) fn shuffle_in(_input: &mut [u8]) {} | ||
| pub(crate) fn shuffle_out(_input: &mut [u8]) {} | ||
|
|
||
| #[cfg(test)] | ||
| use soft as soft_test; | ||
| } | ||
| } | ||
|
|
||
| #[cfg(test)] | ||
| #[path = "block_mix/soft.rs"] | ||
| mod soft_test; |
Member
Author
There was a problem hiding this comment.
This approach was importing it twice
tarcieri
commented
Apr 21, 2026
Comment on lines
65
to
-100
| @@ -96,8 +102,8 @@ impl Params { | |||
|
|
|||
| Ok(Params { | |||
| log_n, | |||
| r: r as u32, | |||
| p: p as u32, | |||
Member
Author
There was a problem hiding this comment.
Previously it was being cast from u32 to usize and back to u32. While there are checks that should work, it seems more straightforward not to cast it back and forth when we're given and want a u32.
Enables and fixes the workspace-level lints added in #884, which is a standard configuration we're using across repositories
tarcieri
force-pushed
the
scrypt/workspace-level-lints
branch
from
08efcb3 to
d71b52f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables and fixes the workspace-level lints added in #884, which is a standard configuration we're using across repositories