ecdsa: use FromDigest trait; RFC6979 fixups#134
Merged
Conversation
- Uses the `FromDigest` trait to automatically convert message digests into a `C::Scalar` value - Updates `SignPrimitive` and `VerifyPrimitive` to accept a scalar - Updates the `dev` module accordingly with the above - Exposes the `ecdsa::signer::rfc6979` module and makes the `generate_k` method `pub`
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
==========================================
- Coverage 37.60% 37.30% -0.30%
==========================================
Files 7 7
Lines 250 252 +2
==========================================
Hits 94 94
- Misses 156 158 +2
Continue to review full report at Codecov.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FromDigesttrait to automatically convert message digests into aC::ScalarvalueSignPrimitiveandVerifyPrimitiveto accept a scalardevmodule accordingly with the aboveecdsa::signer::rfc6979module and makes thegenerate_kmethodpub