ml-dsa: implement KeyInit, KeyExport, KeySizeUser#1342
Merged
Conversation
Implements these traits sourced from the `crypto-common` crate. Also implements the `Generate` trait for key generation, replacing the previous `KeyGen` trait, which this commit deprecates in favor of using `KeyInit` and `Generate`. This also adds a `getrandom` feature that forwards through to `crypto-common`, making methods available on the `Generate` trait when enabled.
tarcieri
force-pushed
the
ml-dsa/crypto-common-key-traits
branch
from
8875531 to
9f256eb
Compare
tarcieri
added a commit
that referenced
this pull request
May 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements these traits sourced from the
crypto-commoncrate.Also implements the
Generatetrait for key generation, replacing the previousKeyGentrait, which this commit deprecates in favor of usingKeyInitandGenerate.This also adds a
getrandomfeature that forwards through tocrypto-common, making methods available on theGeneratetrait when enabled.