ecdsa: have RecoverableSignPrimitive return a bool flag#175
Merged
Conversation
tarcieri
force-pushed
the
ecdsa/recoverable-signature-boolean-flag
branch
2 times, most recently
from
a92f4a7 to
cfeff92
Compare
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
==========================================
- Coverage 49.54% 49.20% -0.34%
==========================================
Files 7 8 +1
Lines 436 439 +3
==========================================
Hits 216 216
- Misses 220 223 +3
Continue to review full report at Codecov.
|
...as opposed to using a separate associated type. As it were, this is how the method is documented. It was changed at some point but the comments were never updated.
tarcieri
force-pushed
the
ecdsa/recoverable-signature-boolean-flag
branch
from
cfeff92 to
8f90ecc
Compare
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 27, 2020
Impls the `RecoverableSignPrimitive` trait revived in RustCrypto/signatures#175. This provides low-level support for computing recoverable signatures.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 27, 2020
Impls the `RecoverableSignPrimitive` trait revived in RustCrypto/signatures#175. This provides low-level support for computing recoverable signatures.
Merged
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 27, 2020
Impls the `RecoverableSignPrimitive` trait revived in RustCrypto/signatures#175. This provides low-level support for computing recoverable signatures.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 27, 2020
Impls the `RecoverableSignPrimitive` trait revived in RustCrypto/signatures#175. This provides low-level support for computing recoverable signatures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...as opposed to using a separate associated type.
As it were, this is how the method is documented. It was changed at some point but the comments were never updated.