Add keccak::f1600x{2,4,8}#4
Closed
bwesterb wants to merge 1 commit into
Closed
Conversation
|
On a On a |
Member
|
Sorry for the late reply! I will try to review this PR in near future. Meanwhile can you add test vectors for the added functions? |
Author
|
I've added tests. |
Author
|
Have you taken a look? |
Merged
Member
|
Obsoleted by #8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working Rust implementations of hash-based signature schemes. For them it would be great to have parallel (x2, x4, x8) versions of
f1600.This simple PR adds such parallel versions using
packed_simd.On my old Haswell I see
So
f1600x4takes 161ns for a singlef1600, which makes it 2.6x faster than fourf1600s.Some notes
packed_simdis still only available for nightly, so I've put these vectorized functions behind a feature gate.f1600xnfunctions are created by a macro. We could instead create a trait for all operations we use onu64xn(and evenu64) and makef1600x2, ...f1600x8andf1600instances of a_f1600<T>.