chacha20: simplify implementation#76
Merged
Merged
Conversation
The original implementation was unnecessarily complicated. This removes a bunch of needlessly complex code. This has no measurable effect on performance.
tarcieri
changed the title
tarcieri
commented
Jan 15, 2020
| iv: [u32; IV_WORDS], | ||
| counter: u64, | ||
| ) -> [u32; STATE_WORDS] { | ||
| fn rounds(&mut self, count: usize) -> [u32; STATE_WORDS] { |
Member
Author
There was a problem hiding this comment.
Additionally this parameterizes the number of rounds enabling the implementation of ChaCha8 and ChaCha12. Again, this comes at no cost to performance (or constant-time, as the number of rounds is a constant).
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original implementation was unnecessarily complicated. This removes a bunch of needlessly complex code.
This has no measurable effect on performance.