Skip to content

signature: PrehashSignature is this trait still needed? #1917

@carloskiki

Description

@carloskiki

The derive feature of signature is removed in version 3.0.0, and I believe PrehashSignature was used as a helper to derive the Signer/Verifier traits. Now that derive is removed, do we still need this trait? IMHO it feels weird that this is implemented on signatures rather than the signing/verifying keys, because the associated Digest type can only be seen as a "preference". When DigestSigner is implemented, the user must provide the correct digest algorithm, which I think makes a better API.

Note: there was already a motion to remove the trait in RustCrypto/signatures#27.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions