elliptic-curve: rename ElementBytes => FEBytes#288
Closed
tarcieri wants to merge 1 commit into
Closed
Conversation
Member
Author
|
Going to leave this one open a bit to gauge what people think. |
tarcieri
commented
Sep 4, 2020
| pub type ElementBytes<C> = GenericArray<u8, <C as Curve>::FieldSize>; | ||
| /// Byte array containing a serialized field element, i.e. an element | ||
| /// of the given curve's base or scalar fields. | ||
| pub type FEBytes<C> = GenericArray<u8, <C as Curve>::FieldSize>; |
Member
Author
There was a problem hiding this comment.
@str4d I've noticed the ff and group crates use a "Repr" naming convention here... do you think something like FERepr would be better?
It's not immediately clear that "Element" in `ElementBytes` refers to a field element. This is a shorter alternative, although it uses an acronym for field element and therefore may be less clear.
tarcieri
force-pushed
the
elliptic-curve/rename-febytes
branch
from
862ed03 to
cb7b1c5
Compare
Member
Author
|
Closing in favor of #296 |
dns2utf8
pushed a commit
to dns2utf8/traits
that referenced
this pull request
Jan 24, 2023
Bumps [zeroize](https://github.com/RustCrypto/utils) from 1.5.3 to 1.5.4. - [Release notes](https://github.com/RustCrypto/utils/releases) - [Commits](RustCrypto/utils@zeroize-v1.5.3...zeroize-v1.5.4) --- updated-dependencies: - dependency-name: zeroize dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some type name bikeshedding...
It's not immediately clear that "Element" in
ElementBytesrefers to a field element.This is a shorter alternative, although it uses an acronym for field element and therefore may be less clear.