Skip to content

Add info.plist to fix Carthage installation#44

Merged
ashfurrow merged 1 commit intoRxSwiftCommunity:masterfrom
mono0926:fix-carthage-installation
Sep 14, 2017
Merged

Add info.plist to fix Carthage installation#44
ashfurrow merged 1 commit intoRxSwiftCommunity:masterfrom
mono0926:fix-carthage-installation

Conversation

@mono0926
Copy link
Copy Markdown
Member

By #42 , info.plist had been deleted, and so Carthage installation is failed with this error log.

Failed to read file or folder at /Users/mono/Library/Caches/org.carthage.CarthageKit/DerivedData/9.0_9A235/NSObject-Rx/3.0.0/Build/Products/Release-iphoneos/NSObject_Rx.framework

So I added info.plist to fix Carthage installation.

@ashfurrow
Copy link
Copy Markdown
Member

Thanks! Sorry for the problem. After merging do we need to make a release of the library for Carthage to work?

@ashfurrow ashfurrow merged commit 59299c7 into RxSwiftCommunity:master Sep 14, 2017
@ashfurrow
Copy link
Copy Markdown
Member

Thanks a lot for contributing! I've invited you to join the RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like more information on what that means, check out our contributor guidelines and feel free to reach out with any questions.

@mono0926 mono0926 deleted the fix-carthage-installation branch September 14, 2017 22:18
@mono0926
Copy link
Copy Markdown
Member Author

@ashfurrow

After merging do we need to make a release of the library for Carthage to work?

If it is possible, I'd like you to release.
But I can install by specifying master branch now, so I don't care particularly.

Thanks a lot for contributing! I've invited you to join the RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like more information on what that means, check out our contributor guidelines and feel free to reach out with any questions.

Thanks a lot, I gladly accepted 😄

@ashfurrow
Copy link
Copy Markdown
Member

Cool! I've release 3.0.1 with this fix. Carthage support is an area I sometimes neglect – if there's any problems in the future, or ways we could improve Carthage support, please open an issue 👍

@mono0926
Copy link
Copy Markdown
Member Author

@ashfurrow

Thanks, it works fine with github "RxSwiftCommunity/NSObject-Rx" 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants