Ensure running unregisterDelegate.dispose() on main thread.

[mongris]

Fixed issue #18

[dangthaison91]

Thanks for your PR @mongris. I already used .observeOn(MainScheduler()), do you think
adding subscribeOn(MainScheduler()) will help?

[mongris]

@dangthaison91 Unfortunately it's not working. I have upload a simple project to repo this issue:
https://github.com/RxSwiftCommunity/RxASDataSources/files/1941081/RxASDataSourcesCrashSample.zip

[fumito-ito]

@mongris sorry for delay. I checked your code and commented. Please check it.

[fumito-ito]

How about usingScheduledDisposable ?

let disposable = Disposable.create { /* do something */ }
ScheduledDisposable(scheduler: MainScheduler(), disposable: disposable)

[fumito-ito]

I found that following code cause #18

let subscription = self.asObservable()
                 .observeOn(MainScheduler())
                 // and more...

but following does not cause same problems without your patches.

             let subscription = self.asObservable()
                 .catchError { error in
                     bindingErrorToInterface(error)
                     return Observable.empty()
                 }
                 // source can never end, otherwise it would release the subscriber, and deallocate the data source
                 .concat(Observable.never())
                 .takeUntil(object.rx.deallocated)
                 .observeOn(MainScheduler()) // <= Move to here

Do you know why ? I want to make code more Rx-like if we can.

[mongris]

@fumito-ito Sorry for my delay.
Your patch looks more reasonable.
I don't know why need to move .observeOn(MainScheduler()) after .takeUntil(object.rx.deallocated) but it works with ScheduledDisposable(scheduler: MainScheduler(), disposable: disposable).
Can you merge your patch it into the next release?

[mongris]

@fumito-ito I found another solution:

The problem is unregisterDelegate is related with an ASNode which will deinit in background thread(ASDeallocThread). We can schedule unregisterDelegate into main scheduler since it is a Dispsoable object:

            let unregisterDelegate = ScheduledDisposable(
                scheduler: MainScheduler.instance,
                disposable: DelegateProxy.installForwardDelegate(dataSource, retainDelegate: retainDataSource, onProxyForObject: object)
            )

[fumito-ito]

@mongris Great ! your second solution looks better than others. could you update your PR to wrap unregisterDelegate with ScheduledDisposable ?

[dangthaison91]

LGTM. Thanks!!!

[dangthaison91]

Thanks @mongris and @fumito-ito

[rxswiftcommunity]

Thanks a lot for contributing @mongris! I've invited you to join the
RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like
more information on what this means, check out our contributor guidelines
and feel free to reach out with any questions.

Generated by 🚫 dangerJS