Skip to content

RxSwift 5.1.1 support#40

Merged
dangthaison91 merged 8 commits into
RxSwiftCommunity:masterfrom
foxware00:master
Apr 8, 2020
Merged

RxSwift 5.1.1 support#40
dangthaison91 merged 8 commits into
RxSwiftCommunity:masterfrom
foxware00:master

Conversation

@foxware00
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread RxASDataSources.podspec Outdated
Comment thread RxASDataSources.podspec Outdated
@foxware00
Copy link
Copy Markdown
Contributor Author

@dangthaison91 Good idea, removed minor versions

Copy link
Copy Markdown
Collaborator

@dangthaison91 dangthaison91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, Thanks @foxware00

@foxware00
Copy link
Copy Markdown
Contributor Author

@dangthaison91 Happy for me to bump to 0.5.0 seeing as the dependency change is breaking?

@dangthaison91
Copy link
Copy Markdown
Collaborator

@foxware00 I think 0.5 is better as it is aligned with Swift and RxSwift version.

@dangthaison91 dangthaison91 merged commit 50dd82c into RxSwiftCommunity:master Apr 8, 2020
@rxswiftcommunity
Copy link
Copy Markdown

Thanks a lot for contributing @foxware00! I've invited you to join the
RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like
more information on what this means, check out our contributor guidelines
and feel free to reach out with any questions.

Generated by 🚫 dangerJS

@foxware00
Copy link
Copy Markdown
Contributor Author

@dangthaison91 Would you be able to make a release in GitHub so others know about the release, please. I'm unable to do so or fetch the changes.

@dangthaison91
Copy link
Copy Markdown
Collaborator

dangthaison91 commented Apr 16, 2020

Just bumped new pod version @foxware00 :D

--------------------------------------------------------------------------------
 🎉  Congrats
 🚀  RxASDataSources (0.5.0) successfully published
 📅  April 16th, 21:24
 🌎  https://cocoapods.org/pods/RxASDataSources
 👍  Tell your friends!
--------------------------------------------------------------------------------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants