Skip to content

Add layout element binder to ASDisplayNode#13

Merged
GeekTree0101 merged 4 commits intoRxSwiftCommunity:masterfrom
OhKanghoon:feature/asdisplaynode+rx
Mar 4, 2019
Merged

Add layout element binder to ASDisplayNode#13
GeekTree0101 merged 4 commits intoRxSwiftCommunity:masterfrom
OhKanghoon:feature/asdisplaynode+rx

Conversation

@OhKanghoon
Copy link
Member

@OhKanghoon OhKanghoon commented Mar 4, 2019

Add layout element binder to ASDisplayNode

  • width / minWidth / maxWidth
  • height / minHeight / maxHeight
  • preferredSize / minSize / maxSize

Modify README / CI Script

  • CI Link in README
  • CI script (travis.yml)

@GeekTree0101 GeekTree0101 self-assigned this Mar 4, 2019
@GeekTree0101 GeekTree0101 self-requested a review March 4, 2019 05:45
@GeekTree0101 GeekTree0101 added the enhancement New feature or request label Mar 4, 2019
Copy link
Member

@GeekTree0101 GeekTree0101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@GeekTree0101 GeekTree0101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GeekTree0101 GeekTree0101 merged commit b55c8ba into RxSwiftCommunity:master Mar 4, 2019
@rxswiftcommunity
Copy link

Thanks a lot for contributing @OhKanghoon! I've invited you to join the
RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like
more information on what this means, check out our contributor guidelines
and feel free to reach out with any questions.

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants