Support control property#17
Merged
GeekTree0101 merged 2 commits intoRxSwiftCommunity:masterfrom May 21, 2019
OhKanghoon:feature/support-control-property
Merged
Support control property#17GeekTree0101 merged 2 commits intoRxSwiftCommunity:masterfrom OhKanghoon:feature/support-control-property
GeekTree0101 merged 2 commits intoRxSwiftCommunity:masterfrom
OhKanghoon:feature/support-control-property
Conversation
Member
OhKanghoon
commented
May 20, 2019
OhKanghoon
commented
- Support ControlProperty (RxASEditableTextNodeDelegateProxy)
- Modify ASControlTarget (event -> controlEvent etc..)
GeekTree0101
approved these changes
May 20, 2019
Member
GeekTree0101
left a comment
GeekTree0101
left a comment
There was a problem hiding this comment.
LGTM! Thank you
Next time, please separate the pr :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.