Skip to content

Added SectionedViewDataSourceType conformance to table/collection vie…#16

Closed
Granfalloner wants to merge 2 commits into
RxSwiftCommunity:masterfrom
Granfalloner:SectionedViewDataSourceTypeConformance
Closed

Added SectionedViewDataSourceType conformance to table/collection vie…#16
Granfalloner wants to merge 2 commits into
RxSwiftCommunity:masterfrom
Granfalloner:SectionedViewDataSourceTypeConformance

Conversation

@Granfalloner
Copy link
Copy Markdown
Collaborator

@Granfalloner Granfalloner commented Feb 2, 2018

…w data sources. It eliminates the need to manually reimplement functionality already present in RxCocoa (like modelSelected, modelDeselected, etc).

@icanzilb
Copy link
Copy Markdown
Member

icanzilb commented Feb 2, 2018

I'll have a look! Since the class supports SectionedViewDataSourceType how is the section support implemented?

@Granfalloner
Copy link
Copy Markdown
Collaborator Author

Granfalloner commented Feb 2, 2018

I think naming of protocol SectionedViewDataSourceType is somewhat misleading. It does not require you to implement sectioned data source - it's rather general protocol that requires you to make sure your data source can provide item at given index path (which includes section as well). For example, RxCocoa implementation of non-sectioned RxTableViewReactiveArrayDataSource also conforms to this protocol, although it does not support sections.

…w delegates. It eliminates the need to manually reimplement functionality already present in RxCocoa (like modelSelected, modelDeselected, etc).
@Granfalloner Granfalloner force-pushed the SectionedViewDataSourceTypeConformance branch from 33a2ec3 to 42c8757 Compare November 14, 2018 18:09
@Granfalloner Granfalloner deleted the SectionedViewDataSourceTypeConformance branch November 15, 2018 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants