ci: Review PR #496 - Reduce usage of token with elevated permissions#514
Open
dellagustin-sap wants to merge 1 commit into
Open
ci: Review PR #496 - Reduce usage of token with elevated permissions#514dellagustin-sap wants to merge 1 commit into
dellagustin-sap wants to merge 1 commit into
Conversation
This commit refactors the `release.yml` workflow to to reduce the usage of the token generated with the GitHub app. actions/checkout is now using the default token and not persisting credentials, as they are not needed (e.g., _Upload VSIX to releases_ receives the token through the environment. The token is now generated just before it is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the
release.ymlworkflow to to reduce the usage of the token generated with the GitHub app.actions/checkout is now using the default token and not persisting credentials, as they are not needed (e.g., Upload VSIX to releases receives the token through the environment.
The token is now generated just before it is needed.