[BREAKING] normalizer: Rename optional parameter "translator" #96
Merged
Conversation
This should future-proof the normalizer API to allow for eventually passing translator objects/instances instead of a simple string. BREAKING CHANGE: Renamed parameter "translator" of functions generateDependencyTree and generateProjectTree to "translatorName"
argument Parameters now need to be passed in the options object. No breaking change as the static translator is private API.
RandomByte
added a commit
to SAP/ui5-cli
that referenced
this pull request
Jan 9, 2019
Relevant API change: SAP/ui5-project#96
RandomByte
changed the title
matz3
approved these changes
Jan 9, 2019
9 tasks
RandomByte
added a commit
to SAP/ui5-cli
that referenced
this pull request
Jan 9, 2019
Relevant API change: SAP/ui5-project#96
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 24, 2025
Relevant API change: SAP/ui5-project#96
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 25, 2025
Relevant API change: SAP/ui5-project#96
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 26, 2025
Relevant API change: SAP/ui5-project#96
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should future-proof the normalizer API to allow for eventually passing
translator objects/instances instead of a simple string.
BREAKING CHANGE: Renamed parameter "translator" of functions generateDependencyTree and generateProjectTree to "translatorName"
Downstream adaptions: SAP/ui5-cli#112