Add enterprise data residency guard#164
Open
evilfps wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a deterministic “data residency guard” module to evaluate export/webhook transfer decisions against tenant policy and produce auditable artifacts (dashboard metrics, webhook envelopes, export manifests, and reviewer-friendly reports).
Changes:
- Introduces core residency evaluation engine with findings, digests, webhook events, export manifests, and text report rendering.
- Adds synthetic sample input data plus a demo script for generating a text report.
- Adds Node test coverage validating decisions, metrics, digest stability, and manifest output.
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| enterprise-data-residency-guard/src/data-residency-guard.js | Implements residency evaluation, findings, dashboard summary, webhook events, export manifest, and text report. |
| enterprise-data-residency-guard/test/data-residency-guard.test.js | Adds tests for policy decisions, dashboard metrics, deterministic digests, and report rendering. |
| enterprise-data-residency-guard/scripts/demo.js | Adds a runnable demo that loads sample input and prints a text report. |
| enterprise-data-residency-guard/package.json | Defines scripts for syntax check, tests, and demo execution (Node-only, no deps). |
| enterprise-data-residency-guard/data/sample-residency-input.json | Provides synthetic tenants/destinations/records that exercise cross-border, PHI, and embargo rules. |
| enterprise-data-residency-guard/docs/requirement-map.md | Maps module outputs to issue #19 requirement areas for review/acceptance. |
| enterprise-data-residency-guard/README.md | Documents what the module covers and how to run checks/tests/demo. |
| README.md | Adds a top-level pointer to the new submodule. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| return { | ||
| ...payload, | ||
| signature: `sha256=${stableDigest(payload)}` |
Comment on lines
+96
to
+107
| if (crossBorder && tenant.policy.requiresSccForNonAdequateRegion && !destination.adequacy) { | ||
| decision = raiseDecision(decision, "blocked"); | ||
| findings.push({ | ||
| code: "NO_ADEQUACY_OR_SCC", | ||
| severity: "critical", | ||
| message: "Destination has no adequacy decision and no SCC evidence", | ||
| evidence: { | ||
| regimes: tenant.regimes, | ||
| destinationRegion: destination.region | ||
| } | ||
| }); | ||
| } |
Comment on lines
+30
to
+33
| return crypto | ||
| .createHash("sha256") | ||
| .update(stableStringify(value)) | ||
| .digest("hex"); |
Comment on lines
+221
to
+229
| queue: results | ||
| .filter((result) => result.decision !== "approved") | ||
| .map((result) => ({ | ||
| id: result.id, | ||
| tenantName: result.tenantName, | ||
| decision: result.decision, | ||
| topFinding: result.findings[0]?.code ?? "NONE" | ||
| })) | ||
| }; |
|
|
||
| - Synthetic data only. No credentials, protected health data, or real institution records. | ||
| - Zero dependencies. The logic uses Node built-ins so reviewers can run it offline. | ||
| - The sample shows one blocked PHI transfer, two manual reviews, and approved in-region exports. |
Author
|
Fixed in latest push. Switched webhook signatures to HMAC, added SCC evidence fields, removed duplicate digest helper, ranked queue findings by severity, and corrected the README sample count. |
Author
|
Following up here. The Algora claim is still pending. Happy to turn around review notes quickly if anything needs adjustment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #19
Adds a data residency guard for enterprise exports and webhooks.
Covers:
Demo:
Tested: