Skip to content

feat(git): carry the PR head SHA on PullRequestChanged #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pomdapis merged 1 commit into from
Jul 24, 2026
Merged

feat(git): carry the PR head SHA on PullRequestChanged #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Abstractions/Compendium.Abstractions.Git/Webhooks/IGitWebhookIngestor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,16 @@ public sealed record TagPushed(string Tag, string CommitSha) : GitWebhookEvent;
/// <param name="Number">The pull request number.</param>
/// <param name="SourceReference">The source branch.</param>
/// <param name="TargetReference">The target branch.</param>
/// <param name="SourceHeadSha">
/// The head commit SHA of the source branch, when the provider reports it —
/// CI/CD consumers need it to build or deploy the exact proposed revision.
/// </param>
public sealed record PullRequestChanged(
string Action,
int Number,
string SourceReference,
string TargetReference) : GitWebhookEvent;
string TargetReference,
string? SourceHeadSha = null) : GitWebhookEvent;

/// <summary>
/// A pipeline run reached a terminal state.
Expand Down
6 changes: 4 additions & 2 deletions src/Adapters/Compendium.Adapters.GitHub/Webhooks/GitHubWebhookIngestor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,12 @@ private static GitWebhookEvent TranslatePullRequest(JsonElement root, string del
var pr = GetProperty(root, "pull_request");
var action = GetString(root, "action") ?? string.Empty;
var number = GetInt(root, "number") ?? GetInt(pr, "number") ?? 0;
var source = GetString(GetProperty(pr, "head"), "ref") ?? string.Empty;
var head = GetProperty(pr, "head");
var source = GetString(head, "ref") ?? string.Empty;
var targetRef = GetString(GetProperty(pr, "base"), "ref") ?? string.Empty;
var headSha = GetString(head, "sha");

return new GitWebhookEvent.PullRequestChanged(action, number, source, targetRef)
return new GitWebhookEvent.PullRequestChanged(action, number, source, targetRef, headSha)
{
DeliveryId = deliveryId,
Repository = repository,
Expand Down
17 changes: 16 additions & 1 deletion tests/Unit/Compendium.Adapters.GitHub.Tests/GitHubWebhookIngestorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ public void Parse_TagPush_ProducesATagPushedEvent()
public void Parse_PullRequest_ProducesAPullRequestChangedEvent()
{
var body = """
{"action":"opened","number":42,"pull_request":{"head":{"ref":"feature"},"base":{"ref":"main"}},
{"action":"opened","number":42,"pull_request":{"head":{"ref":"feature","sha":"headsha42"},"base":{"ref":"main"}},
"repository":{"full_name":"acme/billing"}}
""";

Expand All @@ -106,6 +106,21 @@ public void Parse_PullRequest_ProducesAPullRequestChangedEvent()
pr.Number.Should().Be(42);
pr.SourceReference.Should().Be("feature");
pr.TargetReference.Should().Be("main");
pr.SourceHeadSha.Should().Be("headsha42");
}

[Fact]
public void Parse_PullRequestWithoutHeadSha_LeavesSourceHeadShaNull()
{
var body = """
{"action":"opened","number":7,"pull_request":{"head":{"ref":"feature"},"base":{"ref":"main"}},
"repository":{"full_name":"acme/billing"}}
""";

var result = _ingestor.Parse(Delivery("pull_request", body), Secret);

var pr = result.Value.Should().BeOfType<GitWebhookEvent.PullRequestChanged>().Subject;
pr.SourceHeadSha.Should().BeNull();
}

[Fact]
Expand Down
Loading