-
Notifications
You must be signed in to change notification settings - Fork 2
[FE] SISC1-215 [FEAT] : 외부페이지 UI #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| .container { | ||
| width: 100vw; | ||
| height: 100vh; | ||
| display: flex; | ||
| flex-direction: column; | ||
| } | ||
|
|
||
| .header { | ||
| background: url('../../assets/external-detail-image.png') center no-repeat; | ||
| height: 25%; | ||
| display: flex; | ||
| flex-direction: column; | ||
| align-items: center; | ||
| justify-content: center; | ||
| gap: 8px; | ||
| } | ||
|
|
||
| .title { | ||
| font-weight: 700; | ||
| font-size: 36px; | ||
| line-height: 100%; | ||
| color: #ffffff; | ||
| } | ||
|
|
||
| .divider { | ||
| width: 250px; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| import styles from './External.module.css'; | ||
|
|
||
| const Intro = () => { | ||
| return ( | ||
| <div className={styles.container}> | ||
| <div className={styles.header}> | ||
| <span className={styles.title}>동아리 소개</span> | ||
| <hr className={styles.divider} /> | ||
| </div> | ||
| <div className={styles.info}></div> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default Intro; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| import styles from './External.module.css'; | ||
|
|
||
| const Leaders = () => { | ||
| return ( | ||
| <div className={styles.container}> | ||
| <div className={styles.header}> | ||
| <span className={styles.title}>임원진 소개</span> | ||
| <hr className={styles.divider} /> | ||
| </div> | ||
| <div className={styles.info}></div> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default Leaders; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| import styles from './Main.module.css'; | ||
| import image from '../../assets/external-image.png'; | ||
| import Logo from '../../assets/logo.png'; | ||
| import { Link } from 'react-router-dom'; | ||
|
|
||
| const Main = () => { | ||
| return ( | ||
| <div className={styles.container}> | ||
| <img src={image} alt="메인 사진" className={styles.image} /> | ||
| <nav className={styles.menu}> | ||
| <ul> | ||
| <li> | ||
| <Link to="/main/intro">동아리 소개</Link> | ||
| </li> | ||
| <li> | ||
| <Link to="/main/leaders">임원소개</Link> | ||
| </li> | ||
| <li> | ||
| <Link to="/main/portfolio">운용 포트폴리오</Link> | ||
| </li> | ||
| <li> | ||
| <Link to="/">웹사이트</Link> | ||
| </li> | ||
| </ul> | ||
| </nav> | ||
| <div className={styles.info}> | ||
| <img src={Logo} alt="로고" className={styles.logo} /> | ||
| <h1 className={styles.title}>Sejong Investment Scholars Club</h1> | ||
| <h2 className={styles.subTitle}> | ||
| 세투연과 세상을 읽고 미래에 투자하라 | ||
| </h2> | ||
| </div> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default Main; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| .container { | ||
| position: relative; | ||
| width: 100vw; | ||
| height: 100vh; | ||
| overflow: hidden; | ||
| display: flex; | ||
| flex-direction: column; | ||
| } | ||
|
|
||
| .image { | ||
| position: absolute; | ||
| left: 0; | ||
| top: 0; | ||
| width: 100%; | ||
| height: 100%; | ||
| object-fit: cover; | ||
| z-index: -1; | ||
| } | ||
|
|
||
| .menu { | ||
| margin-top: 55px; | ||
| margin-left: 108px; | ||
| box-sizing: border-box; | ||
| } | ||
|
|
||
| .menu ul { | ||
| display: flex; | ||
| gap: 80px; | ||
| list-style: none; | ||
| } | ||
|
|
||
| .menu a { | ||
| text-decoration: none; | ||
| color: #fff; | ||
| font-size: 18px; | ||
| font-weight: 600; | ||
| line-height: 120%; | ||
| letter-spacing: -0.556px; | ||
| } | ||
|
|
||
| .info { | ||
| margin-top: 150px; | ||
| display: flex; | ||
| flex-direction: column; | ||
| justify-content: center; | ||
| align-items: center; | ||
| gap: 40px; | ||
| } | ||
|
|
||
| .logo { | ||
| width: 106px; | ||
| height: 105px; | ||
| } | ||
|
|
||
| .title { | ||
| font-weight: 700; | ||
| font-size: 80px; | ||
| line-height: 100%; | ||
| letter-spacing: 0%; | ||
| color: #ffffff; | ||
| margin: 0; | ||
| } | ||
|
|
||
| .subTitle { | ||
| font-weight: 600; | ||
| font-size: 32px; | ||
| line-height: 146%; | ||
| letter-spacing: 0%; | ||
| color: #ffffff; | ||
| margin: 0; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| import styles from './External.module.css'; | ||
|
|
||
| const Portfolio = () => { | ||
| return ( | ||
| <div className={styles.container}> | ||
| <div className={styles.header}> | ||
| <span className={styles.title}>운용 포트폴리오</span> | ||
| <hr className={styles.divider} /> | ||
| </div> | ||
| <div className={styles.info}></div> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default Portfolio; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
텍스트 불일치: "임원소개" vs "임원진 소개"
네비게이션 링크 텍스트가 "임원소개"이지만, Leaders.jsx 페이지의 실제 제목은 "임원진 소개"입니다. 일관성을 위해 동일한 텍스트를 사용하세요.
📝 Committable suggestion
🤖 Prompt for AI Agents