Skip to content

fix(audit): prevent deletion of webhook endpoint to maintain client a… #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fupelaqu merged 1 commit into from
Jun 18, 2026
Merged

fix(audit): prevent deletion of webhook endpoint to maintain client a… #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 40 additions & 39 deletions stripe/src/main/scala/app/softnetwork/payment/config/StripeApi.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,47 +160,48 @@ object StripeApi {
log.info(s"Webhook endpoint found: ${webhookEndpoint.getId}")
loadSecret(hash) match {
case None =>
Try(webhookEndpoint.delete(requestOptions))
// Not deleting the webhook endpoint, as it may be used by other clients
// Try(webhookEndpoint.delete(requestOptions))
None
case value =>
val url = s"${config.hooksBaseUrl}?hash=$hash"
case _ =>
Try(
webhookEndpoint.update(
WebhookEndpointUpdateParams
.builder()
.addEnabledEvent(
WebhookEndpointUpdateParams.EnabledEvent.ACCOUNT__UPDATED
)
.addEnabledEvent(
WebhookEndpointUpdateParams.EnabledEvent.PERSON__UPDATED
)
.addEnabledEvent(
WebhookEndpointUpdateParams.EnabledEvent.INVOICE__PAYMENT_SUCCEEDED
)
.addEnabledEvent(
WebhookEndpointUpdateParams.EnabledEvent.INVOICE__PAYMENT_FAILED
)
.addEnabledEvent(
WebhookEndpointUpdateParams.EnabledEvent.CUSTOMER__SUBSCRIPTION__DELETED
)
.addEnabledEvent(
WebhookEndpointUpdateParams.EnabledEvent.CUSTOMER__SUBSCRIPTION__UPDATED
)
.addEnabledEvent(
WebhookEndpointUpdateParams.EnabledEvent.CUSTOMER__UPDATED
)
.addEnabledEvent(
WebhookEndpointUpdateParams.EnabledEvent.PAYMENT_METHOD__ATTACHED
)
.addEnabledEvent(
WebhookEndpointUpdateParams.EnabledEvent.PAYMENT_METHOD__DETACHED
)
.setUrl(url)
.build(),
requestOptions
)
)
value
webhookEndpoint
.update(
WebhookEndpointUpdateParams
.builder()
.addEnabledEvent(
WebhookEndpointUpdateParams.EnabledEvent.ACCOUNT__UPDATED
)
.addEnabledEvent(
WebhookEndpointUpdateParams.EnabledEvent.PERSON__UPDATED
)
.addEnabledEvent(
WebhookEndpointUpdateParams.EnabledEvent.INVOICE__PAYMENT_SUCCEEDED
)
.addEnabledEvent(
WebhookEndpointUpdateParams.EnabledEvent.INVOICE__PAYMENT_FAILED
)
.addEnabledEvent(
WebhookEndpointUpdateParams.EnabledEvent.CUSTOMER__SUBSCRIPTION__DELETED
)
.addEnabledEvent(
WebhookEndpointUpdateParams.EnabledEvent.CUSTOMER__SUBSCRIPTION__UPDATED
)
.addEnabledEvent(
WebhookEndpointUpdateParams.EnabledEvent.CUSTOMER__UPDATED
)
.addEnabledEvent(
WebhookEndpointUpdateParams.EnabledEvent.PAYMENT_METHOD__ATTACHED
)
.addEnabledEvent(
WebhookEndpointUpdateParams.EnabledEvent.PAYMENT_METHOD__DETACHED
)
.setUrl(url)
.build(),
requestOptions
)
.getSecret // update secret if changed
).toOption
}
case _ =>
None
Expand Down
Loading