feat(reviewing-prs): native review recovery — one codex reviewer for both species - #9
Merged
Conversation
Owner
Author
Automated review trailEngine: native Final verdict: approve. Round 3 reported: “No actionable correctness defects were found in the full change range.” Findings and routingRound 1:
Round 2:
Round 3: no findings. Verification
Tier judgmentHUMAN tier; not merged.
PR head reviewed and pushed: |
SSFSKIM
added a commit
that referenced
this pull request
Jul 11, 2026
…liation Merges two concurrent changes to the review criteria: the review worker's injection hardening (PR #9 round 2: fixed policy in developer_instructions, ticket text in an explicitly untrusted data file — a0c8e82) and the human's content minimization (never re-instruct what native review already does). Result: the fixed policy carries ONLY the spec-compliance addendum framed as decision discipline, reads the ticket text from the untrusted file, and a ticketless PR (empty criteria file) sends no developer instructions at all. Data file carries ticket requirements only (PR-claims section dropped). Spec Revision Notes 2-4.
…pecies Two codex-workers conclusions overturned by live spikes (2026-07-12): custom criteria ride -c developer_instructions past the --base/[PROMPT] clap wall, and codex-in-codex review works with a 3-env recipe (inner danger-full-access confined by the outer profile + CODEX_CODE_MODE_HOST_PATH + SSL_CERT_FILE). New spec restores the product core: one native 'codex exec review' engine for both worker species via a substrate review-engine.sh; engine-down parks nothing — ticket stays in-review and the sweep retries on an ENGINE-UNAVAILABLE marker. Revision Note 6 + FU-7 correction cross-refs added to the prior spec/shakedown docs.
…rift fixed (Revision Note 1)
…ation for both species
…x reviewer, both species
…review never goes limbo
…ack, sweep retry row
…liation Merges two concurrent changes to the review criteria: the review worker's injection hardening (PR #9 round 2: fixed policy in developer_instructions, ticket text in an explicitly untrusted data file — a0c8e82) and the human's content minimization (never re-instruct what native review already does). Result: the fixed policy carries ONLY the spec-compliance addendum framed as decision discipline, reads the ticket text from the untrusted file, and a ticketless PR (empty criteria file) sends no developer instructions at all. Data file carries ticket requirements only (PR-claims section dropped). Spec Revision Notes 2-4.
SSFSKIM
force-pushed
the
reviewing-review
branch
from
July 11, 2026 20:22
a922b46 to
5098d92
Compare
SSFSKIM
added a commit
that referenced
this pull request
Jul 11, 2026
…liation Merges two concurrent changes to the review criteria: the review worker's injection hardening (PR #9 round 2: fixed policy in developer_instructions, ticket text in an explicitly untrusted data file — a0c8e82) and the human's content minimization (never re-instruct what native review already does). Result: the fixed policy carries ONLY the spec-compliance addendum framed as decision discipline, reads the ticket text from the untrusted file, and a ticketless PR (empty criteria file) sends no developer instructions at all. Data file carries ticket requirements only (PR-claims section dropped). Spec Revision Notes 2-4.
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the review loop's product core: one native
codex exec review --baseengine call returning a compact correctness + spec-compliance verdict for BOTH review-worker species, owned by the new substrate scriptreview-engine.sh.skills/reviewing-prs/scripts/review-engine.sh: temporary out-of-treeCODEX_HOME, authentication inherited from the caller's effective Codex home,SSL_CERT_FILE,CODEX_CODE_MODE_HOST_PATH, nested-onlysandbox_mode=danger-full-accessbehind aCODEX_SANDBOXcheck, fixed review policy viadeveloper_instructions, PR/ticket criteria in an explicitly untrusted data file, and rc passthroughENGINE-UNAVAILABLEmarker)_codex_launchexportsCODEX_CODE_MODE_HOST_PATH--stat)SKILL.mdupdatedSpec: docs/doperpowers/specs/2026-07-12-native-review-recovery-design.md
Plan: docs/doperpowers/plans/2026-07-12-native-review-recovery.md