[autobackport: sssd-2-10] refactoring ipa tests for hostname framework changes. - #8673
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors IPA system tests to utilize the hostname framework, replacing hardcoded hostnames with dynamic references across various test cases. It also introduces a new test for verifying ID view overrides during email lookups. A critical issue was identified where unresolved Git conflict markers were left in the code, which will cause a syntax error during execution.
23a2ac3 to
721f7c6
Compare
|
@danlavu Several |
|
@justin-stephenson, @alexey-tikhonov brought it up that we haven't been able to build centos-stream, so it doesn't have the keytab from sssd-ci-containers. I'll ping you. |
C10s build should be fixed now, let me re-run the system tests |
721f7c6 to
7882206
Compare
|
rerunning c10, will merge if it passes. |
7882206 to
48f6259
Compare
Reviewed-by: Jakub Vávra <jvavra@redhat.com> Reviewed-by: Justin Stephenson <jstephen@redhat.com> Reviewed-by: Madhuri Upadhye <mupadhye@redhat.com> (cherry picked from commit 8f170d0)
|
The pull request was accepted by @jakub-vavra-cz with the following PR CI status: 🟢 CodeQL (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
48f6259 to
8fac838
Compare
This is an automatic backport of PR#8611 refactoring ipa tests for hostname framework changes. to branch sssd-2-10, created by @danlavu.
Caution
@danlavu The patches did not apply cleanly. It is necessary to resolve conflicts before merging this pull request. Commits that introduced conflict are marked with
CONFLICT!.You can push changes to this pull request
Original commits
8f170d0 - refactoring ipa tests for hostname framework changes.
Backported commits
Conflicting Files Information (check for deleted and re-added files)
Original Pull Request Body