Skip to content

[autobackport: sssd-2-10] refactoring ipa tests for hostname framework changes. - #8673

Merged
jakub-vavra-cz merged 1 commit into
SSSD:sssd-2-10from
sssd-bot:SSSD-sssd-backport-pr8611-to-sssd-2-10
Jul 10, 2026
Merged

[autobackport: sssd-2-10] refactoring ipa tests for hostname framework changes.#8673
jakub-vavra-cz merged 1 commit into
SSSD:sssd-2-10from
sssd-bot:SSSD-sssd-backport-pr8611-to-sssd-2-10

Conversation

@sssd-bot

@sssd-bot sssd-bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

This is an automatic backport of PR#8611 refactoring ipa tests for hostname framework changes. to branch sssd-2-10, created by @danlavu.

Caution

@danlavu The patches did not apply cleanly. It is necessary to resolve conflicts before merging this pull request. Commits that introduced conflict are marked with CONFLICT!.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8611-to-sssd-2-10
git checkout SSSD-sssd-backport-pr8611-to-sssd-2-10
git push sssd-bot SSSD-sssd-backport-pr8611-to-sssd-2-10 --force

Original commits
8f170d0 - refactoring ipa tests for hostname framework changes.

Backported commits

  • 23a2ac3 - CONFLICT! refactoring ipa tests for hostname framework changes.

Conflicting Files Information (check for deleted and re-added files)

  • CONFLICT! refactoring ipa tests for hostname framework changes.
On branch SSSD-sssd-backport-pr8611-to-sssd-2-10
You are currently cherry-picking commit 8f170d08a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/tests/system/tests/test_ipa.py

no changes added to commit (use "git add" and/or "git commit -a")

Original Pull Request Body

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors IPA system tests to utilize the hostname framework, replacing hardcoded hostnames with dynamic references across various test cases. It also introduces a new test for verifying ID view overrides during email lookups. A critical issue was identified where unresolved Git conflict markers were left in the code, which will cause a syntax error during execution.

Comment thread src/tests/system/tests/test_ipa.py Outdated
Comment thread src/tests/system/tests/test_ipa.py Fixed
@danlavu
danlavu force-pushed the SSSD-sssd-backport-pr8611-to-sssd-2-10 branch from 23a2ac3 to 721f7c6 Compare May 6, 2026 22:01
@danlavu
danlavu marked this pull request as ready for review May 6, 2026 22:01

@jakub-vavra-cz jakub-vavra-cz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justin-stephenson

Copy link
Copy Markdown
Contributor

@danlavu Several ipa system tests still fail here, do you know why?

@danlavu

danlavu commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

@justin-stephenson, @alexey-tikhonov brought it up that we haven't been able to build centos-stream, so it doesn't have the keytab from sssd-ci-containers. I'll ping you.

@justin-stephenson

Copy link
Copy Markdown
Contributor

@justin-stephenson, @alexey-tikhonov brought it up that we haven't been able to build centos-stream, so it doesn't have the keytab from sssd-ci-containers. I'll ping you.

C10s build should be fixed now, let me re-run the system tests

@justin-stephenson
justin-stephenson force-pushed the SSSD-sssd-backport-pr8611-to-sssd-2-10 branch from 721f7c6 to 7882206 Compare June 10, 2026 14:39
@danlavu

danlavu commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

rerunning c10, will merge if it passes.

@danlavu
danlavu force-pushed the SSSD-sssd-backport-pr8611-to-sssd-2-10 branch from 7882206 to 48f6259 Compare June 23, 2026 00:24
Reviewed-by: Jakub Vávra <jvavra@redhat.com>
Reviewed-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Madhuri Upadhye <mupadhye@redhat.com>
(cherry picked from commit 8f170d0)
@sssd-bot

Copy link
Copy Markdown
Contributor Author

The pull request was accepted by @jakub-vavra-cz with the following PR CI status:


🟢 CodeQL (success)
🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟢 testing-farm:centos-stream-10-x86_64:upstream (success)
🟢 ci / prepare (success)
🟢 ci / system (centos-10) (success)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@sssd-bot
sssd-bot force-pushed the SSSD-sssd-backport-pr8611-to-sssd-2-10 branch from 48f6259 to 8fac838 Compare July 10, 2026 14:28
@jakub-vavra-cz
jakub-vavra-cz merged commit 0d7671a into SSSD:sssd-2-10 Jul 10, 2026
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants