Skip to content

Witches of Dathomir#307

Merged
AconiteX merged 1 commit into
SWG-Source:3.1from
BloodCommando:3.1
Jul 13, 2021
Merged

Witches of Dathomir#307
AconiteX merged 1 commit into
SWG-Source:3.1from
BloodCommando:3.1

Conversation

@BloodCommando

Copy link
Copy Markdown
Contributor

No description provided.

@Cekis

Cekis commented Jul 12, 2021

Copy link
Copy Markdown
Contributor

WOOOP!

@@ -1,3 +1,3 @@
server_template_crc cell_index px py pz qw qx qy qz scripts objvars
h i f f f f f f f s p
object/building/kashyyyk/thm_kash_rodian_bannerpole_s01.iff 0 0 195 0 0 0 0 0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this a placeholder object (and that's why it was removed)?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, essentially buildouts that have nothing placed in them have this as a placeholder. You'll notice the lack of an objid and container column as well.

@@ -1,3 +1,5 @@
server_template_crc cell_index px py pz qw qx qy qz scripts objvars
h i f f f f f f f s p
object/building/kashyyyk/thm_kash_rodian_bannerpole_s01.iff 0 0 195 0 0 0 0 0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placeholder?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placeholder item.

-2 0 object/tangible/npc/rebel_recruiter_spawner.iff 0 1995.84 142 88.46 1 0 0 0 $|
-3 0 object/tangible/ground_spawning/area_spawner.iff 0 2000 142 86 1 0 0 0 systems.spawning.spawner_area fltMaxSpawnTime|2|1.000000|fltMinSpawnTime|2|0.000000|fltRadius|2|3.000000|intDefaultBehavior|0|2|intGoodLocationSpawner|0|0|intSpawnCount|0|3|intSpawnSystem|0|1|registerWithController|0|1|strName|4|rebel_trooper|strSpawnerType|4|area|strSpawns|4|rebel_trooper|$|
9725637 0 object/building/dathomir/spiderclan_breeding_cave.iff 0 1865.082 122.218 285.936 0.99357206 0 -0.11320315 0 theme_park.dungeon.generic_spawner spawn_table|4|datatables/spawning/theme_park/wod_central_dath_cave.iff|$|
9725638 9725637 object/cell/cell.iff 1 0 0 0 1 1.401298E-45 0 0 $|

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the scientific notation values here (e.g. 1.401298E-45). I know it was in some other stuff but we may just want to examine that in the future.

9725613 0 object/tangible/camp/campfire_logs_ash.iff 0 868.106 132.004 1096.13 0.99959 -0.0198944 0.00539792 -0.0198944 $|
1177362 0 object/tangible/poi/spawnegg/exterior_spawnegg.iff 0 865.6707764 132.016098 1094.974731 1 0 0 0 $|
4115630 0 object/building/general/rancor_cave_2.iff 0 1778.21 62.4932 2018.32 0.4924232 0 0.87035596 0 theme_park.dungeon.generic_spawner spawn_table|4|datatables/spawning/theme_park/wod_rancor_cave.iff|$|
4115631 4115630 object/cell/cell.iff 1 0 0 0 1 1.401298E-45 0 0 $|

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flagging these scientific notation numbers here too.

2666092 0 object/tangible/furniture/all/frn_all_tiki_torch_s1.iff 0 513.615 229.5 121.736 1 0 0 0 $|
5655352 0 object/static/structure/general/streetlamp_small_green_style_01.iff 0 496.442 239.711 37.3691 -0.00920357 0 0 0.999958 $|
5655362 0 object/static/structure/general/streetlamp_small_green_style_01.iff 0 609.687 282.362 238.159 -0.00388366 -0.38268 0.00160868 0.923871 $|
-1 0 object/tangible/spawning/static_npc/herald_dathomir_nsister_cave_azzenaj.iff 0 533.26 229 141.61 0.544639035 0 -0.8386705679 0 $|

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Herald NPCs either give a location to a POI (PreCU/PreNGE) or gave a quest. In this case Azzenaj became part of the Singing Mountain Clan's quest NPCs in Witches of Dathomir and this version of her was removed.

if (isIdValid(createdSchematic))
{
destroyObject(self);
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

else ?? get fucked ??

import script.library.jedi;
import script.library.static_item;

public class wod_spider_queen_death extends script.base_script

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if... we just used the loot tables?

import script.library.static_item;
import script.library.utils;

public class wod_spiderconsort_dna extends script.base_script

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regular loot tables

import script.library.static_item;
import script.library.utils;

public class wod_spiderqueen_dna extends script.base_script

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regular loot tables

return SCRIPT_CONTINUE;
}
int randomSpawnObject = rand(0, 4);
if (randomSpawnObject < 0)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is literally impossible

@AconiteX

Copy link
Copy Markdown
Member

These 70+ comments are primarily notes/questions about bad scripting and a few other implementation issues with WoD. Almost all of the comments have nothing to do with @BloodCommando and his amazing work--thank you!! More of just a to-do list for later. Happy to get this pushed in.

@AconiteX
AconiteX merged commit 1816a11 into SWG-Source:3.1 Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants