Fix Imperial Hoth phase 3 tokens never being awarded#409
Merged
Conversation
The imperial_p3_end trigger waits for 5 xport_update events to fire,
which signals that all transports have been accounted for (escaped or
destroyed). Transport escapes fire takeoff_imperial_N -> xport_update,
but transport destructions only sent questUpdate messages and never
generated xport_update task IDs. This meant:
- If all transports escaped: xport_update fired 5 times -> worked
- If any transport was destroyed: xport_update count never reached 5
-> imperial_p3_end never fired -> conclude_imperial_p3 never ran
-> no tokens awarded
Similarly, p3_imperial_minor/major trigger tracking (for bonus tokens)
waited for xport_destroy events, but each individual destruction never
generated them - only the all-5-destroyed compound did.
Fix: add taskId:xport_update and taskId:xport_destroy to each
xport_destroyed_N trigger block so every destroyed transport
contributes to both counts, regardless of how many escape.
Fixes #387
Member
|
👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Imperial Hoth (Echo Base) players received no tokens upon completion because the
imperial_p3_endtrigger—which drives the token award sequence—required 5xport_updatetask ID events, but destroyed transports never generated them.Root cause:
imperial_p3_endfires when 5xport_updateevents accumulate (waitForComplete). Escaped transports firetakeoff_imperial_N → xport_update. Destroyed transports firedquestUpdate p3_transport_destroyedbut noxport_updateorxport_destroy. This meant:xport_update→ worked correctlyxport_updatecount never reached 5 →imperial_p3_endnever fires →conclude_imperial_p3never runs → zero tokensThe minor/major bonus token logic also depended on
xport_destroyaccumulating 3 or 5 times, but the individual destruction triggers didn't generate these IDs either.Fix:
Add
taskId:xport_updateandtaskId:xport_destroyto each of the fivexport_destroyed_Ntrigger blocks so every destroyed transport counts toward both totals, regardless of how many escape.Fixes #387