Implement model, reader, wrapper for valve SKU sis files. #54

HeroponRikiBestest · 2026-01-05T21:47:48Z

This PR is a draft until I do another pass for proper formatting and commenting, as well as more testing, and other requirements that need to be fulfilled.

HeroponRikiBestest · 2026-01-18T21:58:18Z

PR is ready for review. Let me know if there's anything I still need to do, this should be fully complete.

…memory (SabreTools#56) * WIP * WIP 2 * Todo: you're missing a read somehow and getting misaligned by two bytes? maybe properly implementing the buffer will magically fix it * continued blocks my behated * Pre-major-testing * Forgot to add summaries * Attempt to properly roll back. The state i wanted to roll back to wasn't in a commit before. * Figured out the issue with the rolled back commit, this has to be a while loop because of 0 byte files. Reimplemented clean code. * Comment so I don't forget why it's like this * Skip unsupported compression types before opening filestream. * Reenable non-start cab skipping * TODO so i don't forget * TODO so I don't forget * iterate on continued block correctly. * Handle incomplete extraction better * Remove TODOs to ready for PR comments * Missed one * Some minor fixes before rewriting everything * Next round of fixes. * Next set of fixes * Fix debug output

… methods (SabreTools#57) * Attempt 1 * Use private helper class * Remove comment * Add missing summaries * Don't use create pattern * Remove removed variable summary * Reduce what needs to be passed in * Further reduce what needs to be passed in * These didn't get tabbed for some reason * First round of fixes. * Second round of changes * Add a few comments.

* Re-enable extraction from stream * Remove todo pre PR * Properly support all situations, remove whitespace

…stead of living in PortableExecutable (SabreTools#59) * Figure out how to access OverlayAddress in wrapper or reader (ideally the latter) for a non-PE reader/wrapper * Code works * Remove TODOs * First round of fixes. * use constants * remove comment

I had previously been under the assumption that closing always guaranteed a flush. I don't know of any issues that were being caused, but I should push this before i forget.

mnadareski

I'm a bit confused with the naming here. I'm seeing both SkuSis and VDF being used seemingly interchangeably. Is there a difference here in what both mean? Is one preferable over the other? Or is this a subset situation like COFF and PE?

mnadareski · 2026-01-27T19:11:16Z

SabreTools.Serialization/Models/VDF/File.cs

+        /// <summary>
+        /// A JSON Object representing the VDF structure.
+        /// </summary>
+        public JObject? VDFObject { get; set; }


I'm sure this is a complicated question, but why does this have to be a JObject and not another structure?

What other structures would you use? I'm open to others if you have any specific suggestions, JObject was just what I happened to find worked best out of all the various JSON-based options.

mnadareski · 2026-01-27T19:11:27Z

SabreTools.Serialization/Readers/SkuSis.cs

+using System;
+using System.IO;
+using SabreTools.IO.Extensions;
+using File = SabreTools.Data.Models.VDF.File;
+using static SabreTools.Data.Models.VDF.Constants;
+using System.Text;
+using Newtonsoft.Json.Linq;


Ensure usings are ordered

Also just for future reference- how do

using File = SabreTools.Data.Models.VDF.File; using static SabreTools.Data.Models.VDF.Constants;

get alphabetized?
Do I

alphabetize based on the first letter no matter what

alphabetize based on the name of the actual package (in this case SabreTools.Data.whatever)

put them after all the "normal" using statements

mnadareski · 2026-01-27T19:12:45Z

SabreTools.Serialization/Readers/SkuSis.cs

+                if (skuSis == null)
+                    return null;
+
+                if (skuSis.VDFObject == null)
+                    return null;


If both are required, you can replace this by a if (skuSis?.VDFObject == null) check instead.

mnadareski · 2026-01-27T19:13:15Z

SabreTools.Serialization/Readers/SkuSis.cs

+            string json = "{\n"; // Sku sis files have no surrounding curly braces, which json doesn't allow
+            string delimiter = "\"\t\t\""; // KVPs are always quoted, and are delimited by two tabs


These two would likely benefit from being const.

json is the string that gets updated, so that one can't be const, unless you want me to copy it.

mnadareski · 2026-01-27T19:13:35Z

SabreTools.Serialization/Readers/SkuSis.cs

+
+            string json = "{\n"; // Sku sis files have no surrounding curly braces, which json doesn't allow
+            string delimiter = "\"\t\t\""; // KVPs are always quoted, and are delimited by two tabs
+            string? line;


If line is never used outside of the loop, please instantiate it in the loop.

mnadareski · 2026-01-27T19:15:03Z

SabreTools.Serialization/WrapperFactory.cs

+
+            #region SkuSis
+
+            // TODO: add description


TODO: please add description

Weird, I thought I fixed this already, I specifically went through all my TODOs before undrafting. Not sure why this is still here.
That said, I'm also not sure why I said this? Very few of the other regions have descriptions. Do you have any idea why it's there?

mnadareski · 2026-01-27T19:15:10Z

SabreTools.Serialization/WrapperFactory.cs

+            // TODO: add description
+            if (magic.StartsWith(Data.Models.VDF.Constants.SteamSimSidSisSignatureBytes) 
+                || magic.StartsWith(Data.Models.VDF.Constants.SteamCsmCsdSisSignatureBytes))
+                return WrapperType.SkuSis;


Curly braces please

…memory (SabreTools#56) * WIP * WIP 2 * Todo: you're missing a read somehow and getting misaligned by two bytes? maybe properly implementing the buffer will magically fix it * continued blocks my behated * Pre-major-testing * Forgot to add summaries * Attempt to properly roll back. The state i wanted to roll back to wasn't in a commit before. * Figured out the issue with the rolled back commit, this has to be a while loop because of 0 byte files. Reimplemented clean code. * Comment so I don't forget why it's like this * Skip unsupported compression types before opening filestream. * Reenable non-start cab skipping * TODO so i don't forget * TODO so I don't forget * iterate on continued block correctly. * Handle incomplete extraction better * Remove TODOs to ready for PR comments * Missed one * Some minor fixes before rewriting everything * Next round of fixes. * Next set of fixes * Fix debug output

* Re-enable extraction from stream * Remove todo pre PR * Properly support all situations, remove whitespace

…stead of living in PortableExecutable (SabreTools#59) * Figure out how to access OverlayAddress in wrapper or reader (ideally the latter) for a non-PE reader/wrapper * Code works * Remove TODOs * First round of fixes. * use constants * remove comment

I had previously been under the assumption that closing always guaranteed a flush. I don't know of any issues that were being caused, but I should push this before i forget.

HeroponRikiBestest · 2026-01-27T20:59:12Z

I'm a bit confused with the naming here. I'm seeing both SkuSis and VDF being used seemingly interchangeably. Is there a difference here in what both mean? Is one preferable over the other? Or is this a subset situation like COFF and PE?

See the explanation at the top of the Readers file.

https://github.com/SabreTools/SabreTools.Serialization/pull/54/changes#diff-54b774d3290e04aa399006ebbba19aa9a72475efc8265e4057e4d9fe317b0e22R11-R18

…ition

HeroponRikiBestest · 2026-01-27T21:58:26Z

closing and reopening because apparently i don't know how to merge

HeroponRikiBestest added 6 commits January 5, 2026 14:41

Initial implementation

ca115c0

Commit to the right branch this time

1499c84

Use newtonsoft instead of System.Text.Json

be8519a

Don't parse constant strings

9481dd5

Add comments for documentation

e20ed73

Add reader and wrapper tests

2e7f9e1

HeroponRikiBestest mentioned this pull request Jan 7, 2026

Add Steam AppID and DepotID tags SabreTools/SabreTools.RedumpLib#13

Merged

HeroponRikiBestest marked this pull request as ready for review January 18, 2026 21:57

HeroponRikiBestest and others added 18 commits January 22, 2026 21:23

Fix Naming

9f98ef3

Formatting and comment cleanup

6bfe68b

Support WoD info CMP block type

f16ed97

Formatting cleanup

4bfaf36

Re-enable stream extraction for MScab (SabreTools#58)

7f7d0f8

* Re-enable extraction from stream * Remove todo pre PR * Properly support all situations, remove whitespace

Formatting cleanup

2959d82

Use newer "is null" syntax

ee85a84

Use newer "is not null" syntax

4300d94

Fix some errant formatting

a35e58e

Add editorconfig, fix issues

344132b

Apparently didn't rename this

59b918c

Missed this one too

69b6595

Add debug flag to interface definitions (fixes SabreTools#60)

527b09c

Flush before closing in microsoftcabinet.extraction (SabreTools#61)

ecca11e

I had previously been under the assumption that closing always guaranteed a flush. I don't know of any issues that were being caused, but I should push this before i forget.

Clean up some formatting things

8f8d86d

mnadareski reviewed Jan 27, 2026

View reviewed changes

HeroponRikiBestest and others added 2 commits January 27, 2026 15:52

Formatting and comment cleanup

2d751e6

mnadareski and others added 14 commits January 27, 2026 15:52

Formatting cleanup

b50ebff

Re-enable stream extraction for MScab (SabreTools#58)

7213762

* Re-enable extraction from stream * Remove todo pre PR * Properly support all situations, remove whitespace

Formatting cleanup

2eecbdb

Use newer "is null" syntax

27684a4

Use newer "is not null" syntax

8be8e69

Fix some errant formatting

12232fa

Add editorconfig, fix issues

2d31caa

Apparently didn't rename this

5a37906

Missed this one too

58a72f4

Add debug flag to interface definitions (fixes SabreTools#60)

b20af52

Flush before closing in microsoftcabinet.extraction (SabreTools#61)

73cb695

I had previously been under the assumption that closing always guaranteed a flush. I don't know of any issues that were being caused, but I should push this before i forget.

Clean up some formatting things

e809bb4

Apply reformat

50c266b

HeroponRikiBestest added 12 commits January 27, 2026 16:05

Initial round of fixes

b5ca082

Initial implementation

74e3bb4

Commit to the right branch this time

1479f85

Use newtonsoft instead of System.Text.Json

025e4d8

Don't parse constant strings

b5d9bd1

Add comments for documentation

f513fe4

Add reader and wrapper tests

10e6f66

Fix Naming

85713ae

Apply reformat

74ae0dc

Initial round of fixes

bd87c5c

Merge remote-tracking branch 'origin/skusis-addition' into skusis-add…

e54f12f

…ition

Fix

1deb04f

HeroponRikiBestest closed this Jan 27, 2026

HeroponRikiBestest mentioned this pull request Jan 27, 2026

Implement model, reader, wrapper for valve SKU sis files. #62

Merged

		string json = "{\n"; // Sku sis files have no surrounding curly braces, which json doesn't allow
		string delimiter = "\"\t\t\""; // KVPs are always quoted, and are delimited by two tabs

Implement model, reader, wrapper for valve SKU sis files. #54

Implement model, reader, wrapper for valve SKU sis files. #54

Uh oh!

Conversation

HeroponRikiBestest commented Jan 5, 2026

Uh oh!

HeroponRikiBestest commented Jan 18, 2026

Uh oh!

mnadareski left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HeroponRikiBestest Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HeroponRikiBestest commented Jan 27, 2026

Uh oh!

HeroponRikiBestest commented Jan 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

HeroponRikiBestest Jan 27, 2026 •

edited

Loading