Closed
Conversation
…ute (use react router), or neither (redirect and lose chat state)
…to surface to the user
nickgros
reviewed
Dec 12, 2025
| return null | ||
| } | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
This breaks the rules of hooks. Could we instead explicitly pass information/a function via context?
Comment on lines
+118
to
+119
| // Handle actions elements with redirect subelements | ||
| // custom agents are instructed to include these to indicate navigation. |
Collaborator
There was a problem hiding this comment.
To reduce the risk of this functionality while it is being prototyped, could we inject this behavior (e.g. write it in the portal's synapseChatConfig.ts and pass as a prop/context value)? You also wouldn't have to handle all app routing behavior in one function
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
apps/synapse-portal-framework/src/shared-config/synapseChatHelpers.ts
Dismissed
Show dismissed
Hide dismissed
jay-hodgson
added a commit
to jay-hodgson/synapse-web-monorepo
that referenced
this pull request
Mar 23, 2026
…tFloatingActionButton and portal chat agents
Member
Author
|
Many conflicts, updating in a new hackathon-3-23-2026 branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.