Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
==========================================
- Coverage 98.74% 98.73% -0.02%
==========================================
Files 68 69 +1
Lines 3593 4039 +446
==========================================
+ Hits 3548 3988 +440
- Misses 45 51 +6
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates UI view construction to use lazy-initialized subviews and tweaks the Loading → Game navigation transition to animate, with associated test adjustments and a small networking log addition.
Changes:
- Convert several UIKit subview properties to
lazy varand apply small formatting/refactor cleanups in game UI code. - Animate
RootVC.navigateToGameby usingsetViewControllers(..., animated: true)and update navigation tests to allow UIKit to commit stack changes. - Add
Hashableconformances toCard/CardSinglesand log a parsed-result hash inWikimediaClient.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| SwiftIntroTests/Dependencies/ImageCacheTests.swift | Reduces two wait timeouts in cache tests. |
| SwiftIntroTests/App/RootVCTests.swift | Adds short run-loop drains after navigateToGame calls. |
| SwiftIntro/Features/GameSetup/View/GameSetupView.swift | Makes several controls lazy-initialized. |
| SwiftIntro/Features/Game/View/GameView.swift | Makes subviews lazy; minor formatting + moves render into an extension. |
| SwiftIntro/Features/Game/View/CardCVCell.swift | Refactors constraint activation to a loop. |
| SwiftIntro/Features/Game/Model/Values/CardSingles.swift | Adds Hashable conformance. |
| SwiftIntro/Features/Game/Model/Values/Card.swift | Adds Hashable conformance. |
| SwiftIntro/Features/Game/GameVC.swift | Formats collection view registration call across lines. |
| SwiftIntro/Dependencies/Wikimedia/WikimediaClient.swift | Logs parsed.hashValue before delivering results. |
| SwiftIntro/App/RootVC.swift | Animates stack replacement when transitioning Loading → Game. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| // Assert — inverted expectation fails (test fails) if done fires within the timeout | ||
| waitForExpectations(timeout: 0.5) | ||
| waitForExpectations(timeout: 0.1) |
| let waiter = expectation(description: "main queue drain") | ||
| DispatchQueue.main.async { waiter.fulfill() } | ||
| waitForExpectations(timeout: 0.5) | ||
| waitForExpectations(timeout: 0.1) |
| do { | ||
| try done(.success(WikimediaClient.parse(data))) | ||
| let parsed = try WikimediaClient.parse(data) | ||
| logNet.debug("WikimediaClient parsed: \(parsed.hashValue)") |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.