Skip to content

Tags on upload#314

Merged
dtracers merged 50 commits into
masterfrom
tags_on_upload
Oct 12, 2019
Merged

Tags on upload#314
dtracers merged 50 commits into
masterfrom
tags_on_upload

Conversation

@twobackfromtheend

Copy link
Copy Markdown
Member

No description provided.

@todo

todo Bot commented Jul 10, 2019

Copy link
Copy Markdown

Enable tag rename functionality*/}

{/*TODO: Enable tag rename functionality*/}
</ListItemSecondaryAction>
</ListItem>
)
}


This comment was generated by todo based on a TODO comment in edd593f in #314. cc @SaltieRL.

@codecov

codecov Bot commented Jul 11, 2019

Copy link
Copy Markdown

Codecov Report

Merging #314 into master will decrease coverage by 0.17%.
The diff coverage is 89.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #314      +/-   ##
==========================================
- Coverage   64.23%   64.05%   -0.18%     
==========================================
  Files          88       88              
  Lines        5091     5088       -3     
  Branches      705      701       -4     
==========================================
- Hits         3270     3259      -11     
- Misses       1683     1692       +9     
+ Partials      138      137       -1
Flag Coverage Δ
#integration 52.69% <72.41%> (+0.22%) ⬆️
#server 60.43% <89.65%> (-2.11%) ⬇️
Impacted Files Coverage Δ
...d/blueprints/spa_api/utils/query_params_handler.py 73.11% <ø> (-5.01%) ⬇️
...lueprints/spa_api/utils/query_param_definitions.py 100% <ø> (ø) ⬆️
backend/database/wrapper/tag_wrapper.py 84.21% <100%> (-1.32%) ⬇️
backend/database/wrapper/player_wrapper.py 69.33% <100%> (ø) ⬆️
backend/blueprints/spa_api/spa_api.py 65.07% <100%> (ø) ⬆️
backend/initial_setup.py 82.11% <100%> (+0.11%) ⬆️
backend/blueprints/spa_api/errors/errors.py 88.31% <75%> (-0.73%) ⬇️
...nd/blueprints/spa_api/service_layers/replay/tag.py 71.66% <88.23%> (-2.74%) ⬇️
backend/utils/safe_flask_globals.py 53.65% <0%> (-4.88%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93832cc...88b5915. Read the comment docs.

@todo

todo Bot commented Jul 11, 2019

Copy link
Copy Markdown

Readd test for tag using private key

# TODO: Readd test for tag using private key
# assert result[0]['ownerId'] == "76561198018756583"
# assert result[0]['name'].startswith('TAG')
# assert len(result) == 1
response = requests.get(LOCAL_URL + '/api/player/76561198018756583/match_history?page=0&limit=10')


This comment was generated by todo based on a TODO comment in d462443 in #314. cc @SaltieRL.

Comment thread backend/blueprints/spa_api/service_layers/replay/tag.py Outdated
Comment thread backend/blueprints/spa_api/service_layers/replay/tag.py
Comment thread backend/blueprints/spa_api/service_layers/replay/tag.py Outdated
Comment thread backend/blueprints/spa_api/service_layers/replay/tag.py
@dtracers
dtracers merged commit c81b745 into master Oct 12, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the tags_on_upload branch October 12, 2019 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants