[quantization] Remove variant features#618
Merged
mhs4670go merged 2 commits intoSamsung:mainfrom Apr 10, 2026
Merged
Conversation
This commit removes variant features. TICO-DCO-1.0-Signed-off-by: seongwoo <mhs4670go@naver.com>
stamalakhov
reviewed
Apr 10, 2026
| with SuppressWarning(UserWarning, ".*"): | ||
| cm = tico.convert( | ||
| qlayer, | ||
| qlayer.wrapped.as_export_module("prefill").eval(), |
Contributor
There was a problem hiding this comment.
Ahh. @mhs4670go
But what about attention_mask and pos_embeds?
Contributor
Author
There was a problem hiding this comment.
They are internally generated. Isn't it okay not to give them?
Contributor
There was a problem hiding this comment.
But they will be statically generated for every layer, and 2048 seq_len it will require much disk space. So i'm not sure. Externally set parameters were done on purpose to save disk space. But anyway it can be done later.
Contributor
Author
There was a problem hiding this comment.
Ah, I forgot that. Let's revert this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes variant features.
Related: #612
TICO-DCO-1.0-Signed-off-by: seongwoo mhs4670go@naver.com