Protection against current code-block removing#33
Conversation
mxstbr
left a comment
There was a problem hiding this comment.
Can you add some tests that show the broken behavior and what this fixes please? Thanks!
|
If I understand this correctly, when you're in an empty code block with the cursor at the first line, i.e. like so: (where Rather than trying to remove the (non-existant) indentation we just let DraftJS handle it instead? What's not working about this right now? |
|
You can try it here with backspace |
|
Ohhh I see, that's annoying, great catch! Let's get some tests in here to make sure this doesn't happen again accidentally, and then let's ship it 🚀 |
|
I'll try to add tests tomorrow |
|
Awesome, thank you! There's a bunch of tests already, you can just model them after that 👌 |
- fixed previous commit changes; - added test;
Hi, this should go after previous PRs. We don't need
getIndentation.jsanymore.When we are at the beginning of line at our
code-blockwe can remove it by making attempt to go back to previous indent. Here we are checking the current indent and if it zero and this is the first line of thecode-block, we do nothing.