Skip to content

Change how the signalling URL is built #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-macpherson merged 1 commit into from
Oct 18, 2023
Merged

Change how the signalling URL is built #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions library/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 5 additions & 4 deletions library/src/SPSApplication.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,13 @@ export class SPSApplication extends Application {

enforceSpecialSignallingServerUrl() {
// SPS needs a special /ws added to the signalling server url so K8s can distinguish it
this.stream.setSignallingUrlBuilder(()=> {
this.stream.setSignallingUrlBuilder(() => {

// get the current signalling url
let signallingUrl = this.stream.config.getTextSettingValue(TextParameters.SignallingServerUrl);

if (signallingUrl && signallingUrl !== undefined && !signallingUrl.endsWith("/ws")) {
signallingUrl = signallingUrl.endsWith("/") ? signallingUrl + "ws" : signallingUrl + window.location.pathname + "/ws";
}
// add our 'ws' token to the end dependant on whether the URL ends with a '/' or not
signallingUrl = signallingUrl.endsWith("/") ? signallingUrl + "signalling" + window.location.pathname : signallingUrl + "/signalling" + window.location.pathname;

return signallingUrl
});
Expand Down