Override the stream disconnect event to always allow reconnect attempts. Grammar fixes.#55
Merged
david-macpherson merged 1 commit intoScalablePixelStreaming:mainfrom Jul 11, 2024
Conversation
…onnect that always allows a reconnect. also fix some grammar issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
Depending on what closure code was returned from a stream disconnect (among other things) would impact whether or not a reconnect attempt is allowed to be made.
There was also a missing full stop for the AFK message.
Solution
Override the stream disconnect function to always allow a stream reconnect and fix the grammar for the AFK message by adding a full stop.
Documentation
N/A
Test Plan and Compatibility