Upgrade SPS frontend + example to PSInfra 5.5 and functionality to set SS in url parameters.#56
Merged
Upgrade SPS frontend + example to PSInfra 5.5 and functionality to set SS in url parameters.#56
Conversation
…rver to be passed as url arg or in code.
Collaborator
Author
|
I recommend reviewing using: https://github.com/ScalablePixelStreaming/Frontend/pull/56/files?diff=split&w=1 As some whitespace seems to have been messed up. |
dan-tw
approved these changes
Jul 15, 2024
Contributor
|
Tested on CW/AWS/Local
Lgtm! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
SPS frontend was using PSInfra 5.4 so it was not on the latest code.
Additionally, there was no way to specify a signalling server url via url parameters.
Solution
enforceSpecialSignallingServerUrlto handle reading the url parameter if it is set, otherwise fallback to constructing the signalling url as before.Documentation
N/A
Test Plan and Compatibility
- Note: I have not tested using a live deployment of SPS (say on CW) where the signalling url is built using the actual url.